fix(cli): correct scaffolder project path and drop stale WindowsSdkPackageVersion#146
Merged
sundaramramaswamy merged 2 commits intoMay 5, 2026
Conversation
The --create scaffolder and README Quick Start emitted ..\Reactor\Reactor.csproj but the actual path is ..\src\Reactor\Reactor.csproj. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The template pinned WindowsSdkPackageVersion to 10.0.22621.52 which ships CsWinRT 2.1, conflicting with Windows App SDK 2.0-preview2 (CsWinRT 2.2). Let the SDK resolve it automatically, matching what Reactor.csproj already does. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sundaramramaswamy
force-pushed
the
fix/scaffolder-path-and-sdk
branch
from
0e98624 to
3084dd0
Compare
Collaborator
Author
|
All 6 CI checks passed (Build, Unit Tests, Selftests, Pack, CLA, Detect changes). Local verification also confirmed: unit tests (6790 passed, 3 pre-existing failures), selftests (638 passed, 1 pre-existing failure). Ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dotnet run --project src/Reactor.Cli -- --create MyAppgenerated a broken app:..\Reactor\Reactor.csprojbut the actual path is..\src\Reactor\Reactor.csproj10.0.22621.52which ships CsWinRT 2.1, conflicting with Windows App SDK 2.0-preview2 (CsWinRT 2.2). The app builds with MSB3277 warnings and crashes at runtime withFileNotFoundException: WinRT.Runtime 2.2.0.0Fix
WindowsSdkPackageVersion— let the SDK resolve it automatically (matching what Reactor.csproj already does)Verification
Regenerated MyApp, built, and launched successfully with .NET 9 SDK.